Re: git clone broken in next

From: Jeff King <peff@peff.net>
Date: May 15, 2008, 04:44 UTC
Message-ID: <20080515044402.GA3517@sigill.intra.peff.net>
In-Reply-To: <BB5BF79E-ECAE-4F63-AFF1-8C13F23D3D10@sb.org>

On Wed, May 14, 2008 at 11:54:39PM -0400, Kevin Ballard wrote:

Show 8 quoted lines

> Something's horribly wrong in next. I just installed the latest from next 
> and then ran
>
>   git clone git://github.com/kballard/github-gem.git
>
> The resulting repo had absolutely nothing in the workdir. `git status`  
> claims every single file is deleted but not updated. `git checkout -f  
> HEAD` fixed the workdir.

Hmm, builtin-clone does seem to be completely broken. It looks like unpack_trees is not doing its job for some reason, but I haven't looked further. But it surprised me that we aren't testing anything as simple as "clone works". The test below currently fails (though I am getting other test failures which are presumably related).

---

diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
index dc9d63d..593d1a3 100755
--- a/t/t5601-clone.sh
+++ b/t/t5601-clone.sh
@@ -23,4 +23,11 @@ test_expect_success 'clone with excess parameters' '
 
 '
 
+test_expect_success 'clone checks out files' '
+
+	git clone src dst &&
+	test -f dst/file
+
+'
+
 test_done