git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] clone: detect and fail on excess parameters

From
SZEDER Gábor <szeder@ira.uka.de>
Date
Apr 28, 2008, 16:36 UTC
Message-ID
<20080428163642.GA22790@neumann>
In-Reply-To
<7vfxtcsbis.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, Apr 23, 2008 at 10:53:47AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> "git clone [options] $src $dst excess-garbage" simply ignored
> excess-garbage without giving any diagnostic message.  Fix it.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> [...]
> --- a/git-clone.sh
> +++ b/git-clone.sh
> @@ -219,6 +219,7 @@ fi
>  if test -n "$2"
>  then
>  	dir="$2"
> +	test $# == 2 || die "excess parameter to git-clone"
                ^^
I think you mean:
    test $# = 2 || die "excess parameter to git-clone"
I just noticed because it broke t1020-subdirectory at me.

Best, Gábor

Previous: Junio C HamanoNext: Alex Riesen
Message 2 of 3 in “clone: detect and fail on excess parameters”
  1. clone: detect and fail on excess parametersJunio C Hamano, Apr 23, 2008
  2. SZEDER GáborApr 28, 2008
  3. Use "=" instead of "==" in condition as it is more portableAlex Riesen, Apr 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.