From: SZEDER Gábor <szeder@ira.uka.de>
Date: Mon, 28 Apr 2008 16:36:42 GMT
Subject: Re: [PATCH] clone: detect and fail on excess parameters
Message-ID: <20080428163642.GA22790@neumann>
In-Reply-To: <7vfxtcsbis.fsf@gitster.siamese.dyndns.org>

Hi,

On Wed, Apr 23, 2008 at 10:53:47AM -0700, Junio C Hamano wrote:
> "git clone [options] $src $dst excess-garbage" simply ignored
> excess-garbage without giving any diagnostic message.  Fix it.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> [...]
> --- a/git-clone.sh
> +++ b/git-clone.sh
> @@ -219,6 +219,7 @@ fi
>  if test -n "$2"
>  then
>  	dir="$2"
> +	test $# == 2 || die "excess parameter to git-clone"
                ^^
I think you mean:

    test $# = 2 || die "excess parameter to git-clone"

I just noticed because it broke t1020-subdirectory at me.


Best,
Gábor