git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] post-receive-email: fix accidental removal of a trailing space in signature line

From
APAndy Parkins <andyparkins@gmail.com>
Date
Apr 21, 2008, 13:44 UTC
Message-ID
<200804211444.44810.andyparkins@gmail.com>

post-receive-email adds a signature to the end of emails in generate_email_footer(). The signature was separated from the main email body using the standard string "-- ". (see rfc3676)

In revision a6080a0a44d5, Junio's "war on whitespace" removed the trailing whitespace from "-- ", leaving it as "--", which is not a correct signature separator.

This patch restores the missing space, but does it in a way that will not set off the trailing whitespace alarms.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 contrib/hooks/post-receive-email |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 62a740c..4136895 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -202,11 +202,12 @@ generate_email_header()
 
 generate_email_footer()
 {
+	SPACE=" "
 	cat <<-EOF
 
 
 	hooks/post-receive
-	--
+	--${SPACE}
 	$projectdesc
 	EOF
 }
-- 
1.5.5.29.g7134
Message 1 of 1 in “post-receive-email: fix accidental removal of a trailing space in signature line”
  1. post-receive-email: fix accidental removal of a trailing space in signature lineAndy Parkins, Apr 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.