threads / patch / 13196

patchpost-receive-email: fix accidental removal of a trailing space in signature line

Subject: [PATCH] post-receive-email: fix accidental removal of a trailing space in signature line

## tl;dr

One message between Apr 21, 2008 and Apr 21, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Andy Parkins· Apr 21, 2008, 13:44 UTC · lore

post-receive-email adds a signature to the end of emails in generate_email_footer(). The signature was separated from the main email body using the standard string "-- ". (see rfc3676)

In revision a6080a0a44d5, Junio's "war on whitespace" removed the trailing whitespace from "-- ", leaving it as "--", which is not a correct signature separator.

This patch restores the missing space, but does it in a way that will not set off the trailing whitespace alarms.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 contrib/hooks/post-receive-email |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Show changes to contrib/hooks/post-receive-email +2 −1
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 62a740c..4136895 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -202,11 +202,12 @@ generate_email_header()
 
 generate_email_footer()
 {
+	SPACE=" "
 	cat <<-EOF
 
 
 	hooks/post-receive
-	--
+	--${SPACE}
 	$projectdesc
 	EOF
 }
-- 
1.5.5.29.g7134

← back to recent threads