git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-p4: Work around race between p4_edit and p4_change

From
KGKevin Green <kevin.t.green@morganstanley.com>
Date
Apr 11, 2008, 16:27 UTC
Message-ID
<20080411162759.GO22542@morganstanley.com>
In-Reply-To
<20080403195135.GI22542@morganstanley.com>
On 04/03/08 15:51:35, Kevin Green wrote:
Show 18 quoted lines
> On 04/03/08 14:45:38, Kevin Green wrote:
> > On 04/03/08 14:32:32, Simon Hausmann wrote:
> > > 
> > > Last but not least we could of course also generate the entire Files: section 
> > > ourselves, using 'p4 change -o' just to get the rest of the template right.
> > > 
> > > I almost prefer the last approach, since we know the base depot path and the 
> > > relative paths of all edited/added files.
> > > 
> > > What do you think?
> > > 
> > 
> > Thank you...  That's the right approach.  Stop as soon as we get to the Files:
> > section and then just add in the depot + filepath string for each change...
> > 
> 
> And here's the patch that does what we just described...
> 

Haven't heard comment back on this patch. Am wondering if it will be applied to git, or if I need to start thinking about maintaining it myself on my end, or if it's not appropriate and I should re-submit something else.

Thanks
--Kevin
Previous: Kevin Green
Message 5 of 5 in “git-p4: Fix race between p4_edit and p4_change”
  1. git-p4: Fix race between p4_edit and p4_changeKevin Green, Apr 1, 2008
  2. Simon HausmannApr 3, 2008
  3. Kevin GreenApr 3, 2008
  4. git-p4: Work around race between p4_edit and p4_changeKevin Green, Apr 3, 2008
  5. Kevin GreenApr 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.