From: Kevin Green Date: Fri, 11 Apr 2008 16:27:59 GMT Subject: Re: [PATCH] git-p4: Work around race between p4_edit and p4_change Message-ID: <20080411162759.GO22542@morganstanley.com> In-Reply-To: <20080403195135.GI22542@morganstanley.com> On 04/03/08 15:51:35, Kevin Green wrote: > On 04/03/08 14:45:38, Kevin Green wrote: > > On 04/03/08 14:32:32, Simon Hausmann wrote: > > > > > > Last but not least we could of course also generate the entire Files: section > > > ourselves, using 'p4 change -o' just to get the rest of the template right. > > > > > > I almost prefer the last approach, since we know the base depot path and the > > > relative paths of all edited/added files. > > > > > > What do you think? > > > > > > > Thank you... That's the right approach. Stop as soon as we get to the Files: > > section and then just add in the depot + filepath string for each change... > > > > And here's the patch that does what we just described... > Haven't heard comment back on this patch. Am wondering if it will be applied to git, or if I need to start thinking about maintaining it myself on my end, or if it's not appropriate and I should re-submit something else. Thanks --Kevin