git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add test for git rebase --abort

From
Mike Hommey <mh@glandium.org>
Date
Mar 1, 2008, 08:15 UTC
Message-ID
<20080301081511.GA30613@glandium.org>
In-Reply-To
<20080301074511.GB26767@glandium.org>
On Sat, Mar 01, 2008 at 08:45:11AM +0100, Mike Hommey wrote:
Show 15 quoted lines
> On Sat, Mar 01, 2008 at 08:36:12AM +0100, Mike Hommey wrote:
> > On Fri, Feb 29, 2008 at 03:26:01PM -0800, Junio C Hamano wrote:
> > > Mike Hommey <mh@glandium.org> writes:
> > > 
> > > >  The failing test is the third. I don't have enough knowledge in git-rebase
> > > >  to write an appropriate fix, but the problem seems to be in
> > > >  move_to_original_branch, where testing head_name doesn't seem appropriate.
> > > 
> > > Please mark such an "expected to succeed but fails due to
> > > suspected bug" with test_expect_failure.
> > 
> > I was kind of expecting the bug would be fixed before the test be
> > included ;)
> 
> ... and the test actually passes with v1.5.0. I'll bisect.

... and I'm even the one to blame fb6e4e1f3f048898677f3cf177bfcaf60123bd5c is first bad commit

Mike
Previous: Mike HommeyNext: Junio C Hamano
Message 7 of 12 in “Add test for git rebase --abort”
  1. Add test for git rebase --abortMike Hommey, Feb 29, 2008
  2. Junio C HamanoFeb 29, 2008
  3. Johannes SchindelinFeb 29, 2008
  4. Mike HommeyMar 1, 2008
  5. Junio C HamanoMar 1, 2008
  6. Mike HommeyMar 1, 2008
  7. Mike HommeyMar 1, 2008
  8. Junio C HamanoMar 1, 2008
  9. Fix git reset --abort not restoring the right commit under some conditionsMike Hommey, Mar 1, 2008
  10. Mike HommeyMar 1, 2008
  11. Junio C HamanoMar 2, 2008
  12. Junio C HamanoMar 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.