From: Mike Hommey Date: Sat, 01 Mar 2008 08:15:11 GMT Subject: Re: [PATCH] Add test for git rebase --abort Message-ID: <20080301081511.GA30613@glandium.org> In-Reply-To: <20080301074511.GB26767@glandium.org> On Sat, Mar 01, 2008 at 08:45:11AM +0100, Mike Hommey wrote: > On Sat, Mar 01, 2008 at 08:36:12AM +0100, Mike Hommey wrote: > > On Fri, Feb 29, 2008 at 03:26:01PM -0800, Junio C Hamano wrote: > > > Mike Hommey writes: > > > > > > > The failing test is the third. I don't have enough knowledge in git-rebase > > > > to write an appropriate fix, but the problem seems to be in > > > > move_to_original_branch, where testing head_name doesn't seem appropriate. > > > > > > Please mark such an "expected to succeed but fails due to > > > suspected bug" with test_expect_failure. > > > > I was kind of expecting the bug would be fixed before the test be > > included ;) > > ... and the test actually passes with v1.5.0. I'll bisect. ... and I'm even the one to blame fb6e4e1f3f048898677f3cf177bfcaf60123bd5c is first bad commit Mike