Re: [PATCH 1/4] add generic, type aware object chain walker

> mkoegler@auto.tuwien.ac.at (Martin Koegler) writes:
> So I do not have objection to OBJ_ANY (but again, this kind of
> thing needs to be explained in your commit log message), but
> giving the token the same value as OBJ_BAD may not be such a
> cool idea.  

> After all, if the walker callback was told with
> OBJ_ANY that any type of object is Ok, it should still say
> "oops" if the given object said it actually is of type OBJ_BAD.
> E.g. in your [2/4] patch:
> 
>         +static int mark_object(struct object *obj, int type, void *data)
>         +{
>         + ...
>         +	if (type != OBJ_ANY && obj->type != type) {
>         +		objerror(parent, "wrong object type in link");
>         +	}
> 
> if you use the above #define, a tagged object that has a bad
> type will pass this check unnoticed, won't it?