Re: [PATCH 1/4] add generic, type aware object chain walker

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 25, 2008, 03:04 UTC
Message-ID: <20080225030404.GL8410@spearce.org>
In-Reply-To: <12038642373342-git-send-email-mkoegler@auto.tuwien.ac.at>

Martin Koegler <mkoegler@auto.tuwien.ac.at> wrote:

Show 7 quoted lines

> +static int fsck_walk_commit(struct commit *commit, fsck_walk_func walk, void *data)
> +{
> +	struct commit_list *parents = commit->parents;
> +	int result;
> +
> +	if(parse_commit(commit))
> +		return -1;

Hmm. Don't you need to get commit->parenst *after* it is parsed, and not before?

Show 5 quoted lines

> @@ -0,0 +1,10 @@
> +#ifndef GIT_FSCK_H
> +#define GIT_FSCK_H
> +
> +#define OBJ_ANY OBJ_BAD

Its unclear why this macro is necessary.

-- 
Shawn.