Re: What's cooking in git.git (topics)

From: Jeff King <peff@peff.net>
Date: Feb 17, 2008, 12:41 UTC
Message-ID: <20080217124137.GC26031@sigill.intra.peff.net>
In-Reply-To: <7vejbc44hu.fsf@gitster.siamese.dyndns.org>

On Sat, Feb 16, 2008 at 07:59:57PM -0800, Junio C Hamano wrote:

Show 9 quoted lines

> * jk/empty-tree (Wed Feb 13 05:50:51 2008 -0500) 2 commits
>  + add--interactive: handle initial commit better
>  + hard-code the empty tree object
> 
> Jeff added code to deal with the initial commit case better in
> "git-add -i".  Personally I wonder why we bother (if it is an
> initial commit, the user _knows_ there is nothing to diff in the
> HEAD as there is no HEAD yet, heavens), but the code is already
> there so why not.

I was also tempted to just have it output "you can't do this, it's an initial commit." But the change was fairly easy, and I think Kate's point is valid: even though it's an unlikely corner case, new users are likely to start exploring at that corner case, so it helps with new user perception that we handle it gracefully.

-Peff