Re: [PATCH] remove "nohup" from git-help--browse

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Feb 9, 2008, 20:03 UTC
Message-ID: <20080209200351.GC30368@dpotapov.dyndns.org>
In-Reply-To: <200802090653.43280.chriscool@tuxfamily.org>

On Sat, Feb 09, 2008 at 06:53:43AM +0100, Christian Couder wrote:

Show 8 quoted lines

> Le vendredi 8 février 2008, Dmitry Potapov a écrit :
> > There is no good reason to run GUI browsers using "nohup". It does not
> > solve any real problem but creates annoying "nohup.out" files in every
> > directory where git help -w is run.
> 
> That's right, but if you just remove "nohup", then there may be some 
> annoying browser output on the terminal. Perhaps we should also redirect 
> stderr and stdout to /dev/null.

I don't mind this redirection, but I am not sure whether it is the right thing to do, because it may hide relevant error information, and if your browser tends to print irrelevant and annoying messages at start, then perhaps the script to start this browser should be corrected to suppress these output.

So, I want to hear what other people think. If there is no objection, I will add this redirection.

Show 5 quoted lines

> 
> > This patch removes "nohup" from git-help--browse.sh
> 
> "git-help--browse.sh" has been renamed "git-web--browse.sh" in next so we 
> need a similar patch for next.

Okay, I will base my patch on next.

Dmitry