Re: [PATCH] git help -w should not create nohup.out

From: Christian Couder <chriscool@tuxfamily.org>
Date: Feb 8, 2008, 05:37 UTC
Message-ID: <200802080637.04015.chriscool@tuxfamily.org>
In-Reply-To: <7vhcgkm7yy.fsf@gitster.siamese.dyndns.org>

Le vendredi 8 février 2008, Junio C Hamano a écrit :

Show 14 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > Hi,
> >
> > On Fri, 8 Feb 2008, Dmitry Potapov wrote:
> >> git-help--browse uses 'nohup' to launch some browsers.
> >
> > Why?
> >
> > "nohup" should be used to start a program that should persist even
> > after you logged out.  I fail to see how this should be sensible for
> > "git help -w".  So "off with the head", uh, do away with the "nohup", I
> > say!
>
> True.  Christian, what was the reason you added nohup?

I think I was worried about something like this:

1) ssh -Y other_machine
2) git help -w, it opens my browser
3) open many other tabs in the browser
4) exit other_machine, oops my browser with all my tabs is gone

or

1) open my favorite browser and many tabs in it
2) ssh -Y other_machine
3) git help -w, cool it opens a tab in my already opened browser in 1)
4) exit other_machine, oops my browser with all my tabs is gone

I thought it would perhaps help, and it was better to be on the safe side. But I just tested a little and it seems it doesn't change anything.

Also there are some browser that are very verbose on the SDTOUT or STDERR (especially konqueror) and I thought the nohup would also help move the output out of the command line while not discarding it in case it's needed. But I agree that it's not very often usefull and anyway there are better ways to deal with it.

So no problem to do away with the "nohup".

Thanks, Christian.