Re: git-revert is a memory hog

From: Jeff King <peff@peff.net>
Date: Jan 29, 2008, 22:51 UTC
Message-ID: <20080129225123.GB4586@coredump.intra.peff.net>
In-Reply-To: <20080129224558.GA4586@coredump.intra.peff.net>

On Tue, Jan 29, 2008 at 05:45:58PM -0500, Jeff King wrote:

Show 5 quoted lines

> > 	if (rename_dst_nr > rename_limit && rename_src_nr > rename_limit)
> > 		goto cleanup;
> 
> Hrm, yes, I think it can still overflow. (e.g., a 2 by 2^32-1
> situation). But changing it to || isn't right, either; you would

I think the correct solution is just:

  /* check for overflow of square */
  if (rename_dst_nr > ULONG_MAX / rename_src_nr)
          goto cleanup;

-Peff