Re: git-revert is a memory hog

From: Jeff King <peff@peff.net>
Date: Jan 29, 2008, 22:30 UTC
Message-ID: <20080129223010.GA4314@coredump.intra.peff.net>
In-Reply-To: <20080129222007.GA3985@coredump.intra.peff.net>

On Tue, Jan 29, 2008 at 05:20:07PM -0500, Jeff King wrote:

Show 6 quoted lines

> The culprit seems to be diffcore-rename.c:476:
> 
>   mx = xmalloc(sizeof(*mx) * num_create * num_src);
> 
> Where that ends up allocating about 450M. I think this is exactly the
> sort of case that renamelimit was introduced to address.

BTW, a much easier way to see the problem is with:

  git diff -M -l0 d19fbe8a76

It's just a _really_ old commit, and the rename detection has to work on a large number of files.

-Peff