git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: stg clean removes conflicting patch

From
Karl Hasselström <kha@treskal.com>
Date
Jan 25, 2008, 08:04 UTC
Message-ID
<20080125080434.GA5599@diana.vm.bytemark.co.uk>
In-Reply-To
<1201233317.2811.17.camel@dv>
On 2008-01-24 22:55:17 -0500, Pavel Roskin wrote:
> If "stg push" fails, the subsequent "stg clean" will remove the
> patch that could not been applied. I think it's wrong.

I agree. It's consistent -- a conflicting patch is empty -- but clearly the wrong thing to do from a usability perspective.

> I've made a patch for the testsuite that should pass once the bug is
> fixed. Try removing "stg clean" from the test. and it will pass. But
> "stg clean" should make no difference here.
Good!

For known-to-be-failing tests, you can use test_expect_failure. I'll amend your patch to do that when I pick it up (if Catalin doesn't beat me to it).

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Previous: Pavel RoskinNext: Pavel Roskin
Message 2 of 5 in “stg clean removes conflicting patch”
  1. Pavel RoskinJan 25, 2008
  2. Karl HasselströmJan 25, 2008
  3. Pavel RoskinJan 25, 2008
  4. Catalin MarinasJan 25, 2008
  5. Karl HasselströmJan 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.