From: Karl Hasselström <kha@treskal.com>
Date: Fri, 25 Jan 2008 08:04:34 GMT
Subject: Re: stg clean removes conflicting patch
Message-ID: <20080125080434.GA5599@diana.vm.bytemark.co.uk>
In-Reply-To: <1201233317.2811.17.camel@dv>

On 2008-01-24 22:55:17 -0500, Pavel Roskin wrote:

> If "stg push" fails, the subsequent "stg clean" will remove the
> patch that could not been applied. I think it's wrong.

I agree. It's consistent -- a conflicting patch is empty -- but
clearly the wrong thing to do from a usability perspective.

> I've made a patch for the testsuite that should pass once the bug is
> fixed. Try removing "stg clean" from the test. and it will pass. But
> "stg clean" should make no difference here.

Good!

For known-to-be-failing tests, you can use test_expect_failure. I'll
amend your patch to do that when I pick it up (if Catalin doesn't beat
me to it).

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle