git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] t9001: add missing && operators

From
Jeff King <peff@peff.net>
Date
Jan 22, 2008, 03:23 UTC
Message-ID
<20080122032353.GB24758@coredump.intra.peff.net>
In-Reply-To
<20080122031932.GA24758@coredump.intra.peff.net>

The exit value of some commands was not being used for the test output.

Signed-off-by: Jeff King <peff@peff.net>
---
On Mon, Jan 21, 2008 at 10:19:32PM -0500, Jeff King wrote:
> As penance, I'll send some tests in a moment.

This turned into a 3-patch series because of some cleanup needed. This first one is just tightening up the setup tests, which will be modified in the next patch.

 t/t9001-send-email.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 4f6822f..08f7c3d 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -8,7 +8,7 @@ test_expect_success \
     'prepare reference tree' \
     'echo "1A quick brown fox jumps over the" >file &&
      echo "lazy dog" >>file &&
-     git add file
+     git add file &&
      GIT_AUTHOR_NAME="A" git commit -a -m "Initial."'
 
 test_expect_success \
@@ -20,9 +20,9 @@ test_expect_success \
       echo "  echo \"!\$a!\""
       echo "done >commandline"
       echo "cat > msgtxt"
-      ) >fake.sendmail
-     chmod +x ./fake.sendmail
-     git add fake.sendmail
+      ) >fake.sendmail &&
+     chmod +x ./fake.sendmail &&
+     git add fake.sendmail &&
      GIT_AUTHOR_NAME="A" git commit -a -m "Second."'
 
 test_expect_success 'Extract patches' '
-- 
1.5.4.rc3.1130.gd9718-dirty
Previous: Jeff KingNext: Jeff King
Message 6 of 8 in “git-send-email not sending?”
  1. Seth FalconJan 21, 2008
  2. Test of send-email patchGustaf Hendeby, Jan 21, 2008
  3. send-email, fix breakage in combination with --composeGustaf Hendeby, Jan 21, 2008
  4. Seth FalconJan 22, 2008
  5. Jeff KingJan 22, 2008
  6. 1/3 t9001: add missing && operatorsJeff King, Jan 22, 2008
  7. 2/3 t9001: enhance fake sendmail test harnessJeff King, Jan 22, 2008
  8. 3/3 send-email: test compose functionalityJeff King, Jan 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.