git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] send-email, fix breakage in combination with --compose

From
Gustaf Hendeby <hendeby@isy.liu.se>
Date
Jan 21, 2008, 19:57 UTC
Message-ID
<1200945466-21154-2-git-send-email-hendeby@isy.liu.se>
In-Reply-To
<1200945466-21154-1-git-send-email-hendeby@isy.liu.se>

This fixes the subtile bug in git send-email that was introduced into git send-email with

commit aa54892f5ada8282643dc7387b33261c7135d784 send-email: detect invocation errors earlier

causing no patches to be sent out if the --compose flag was used.
Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
---
 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 6c72952..a1a9d14 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -462,7 +462,7 @@ EOT
 		exit(0);
 	}
 
-	@files = ($compose_filename . ".final");
+	@files = ($compose_filename . ".final", @files);
 }
 
 # Variables we set as part of the loop over files
-- 
1.5.4.rc4.1.gbdcdb
Previous: Gustaf HendebyNext: Seth Falcon
Message 3 of 8 in “git-send-email not sending?”
  1. Seth FalconJan 21, 2008
  2. Test of send-email patchGustaf Hendeby, Jan 21, 2008
  3. send-email, fix breakage in combination with --composeGustaf Hendeby, Jan 21, 2008
  4. Seth FalconJan 22, 2008
  5. Jeff KingJan 22, 2008
  6. 1/3 t9001: add missing && operatorsJeff King, Jan 22, 2008
  7. 2/3 t9001: enhance fake sendmail test harnessJeff King, Jan 22, 2008
  8. 3/3 send-email: test compose functionalityJeff King, Jan 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.