git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui/Makefile - Handle $DESTDIR on Cygwin

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jan 18, 2008, 04:01 UTC
Message-ID
<20080118040146.GY24004@spearce.org>
In-Reply-To
<1200628223-2280-1-git-send-email-mlevedahl@gmail.com>
Mark Levedahl <mlevedahl@gmail.com> wrote:
Show 12 quoted lines
> From: Mark Levedahl <mdl123@verizon.net>
> 
> gg_libdir is converted to an absolute Windows path on Cygwin,
> but a later step attempts to prefix $DESTDIR to install to a
> staging directory. Explicitly separate the uses of gg_libdir for
> these two purposes so installation to $DESTDIR will work.
> 
> Signed-off-by: Mark Levedahl <mdl123@verizon.net>
> ---
> git-gui built with this  passed tests on cygwin + tcl/tk 8.5,
> cygwin + normal tcl/tk, and linux. DESTDIR also works on cygwin,
> so I would suggest this rather than the previous patch.

Excellent. I was about to think about writing this patch myself, but you beat me to it. I'm applying this and will include it as part of git-gui 0.9.2, which should be in git 1.5.4.

Thanks.
 
-- 
Shawn.
Previous: Mark Levedahl
Message 5 of 5 in “git-gui/Makefile - Don't convert gg_libdir on Cygwin”
  1. git-gui/Makefile - Don't convert gg_libdir on CygwinMark Levedahl, Jan 5, 2008
  2. Shawn O. PearceJan 16, 2008
  3. Mark LevedahlJan 17, 2008
  4. git-gui/Makefile - Handle $DESTDIR on CygwinMark Levedahl, Jan 18, 2008
  5. Shawn O. PearceJan 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.