git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui/Makefile - Don't convert gg_libdir on Cygwin

From
Mark Levedahl <mdl123@verizon.net>
Date
Jan 5, 2008, 22:32 UTC
Message-ID
<1199572355-2720-1-git-send-email-mdl123@verizon.net>

gg_libdir was converted to an absolute Windows path as a remnant of logic to check for relative / absolute location of libraries, but that does not work on Cygwin. Converting gg_libdir to a Windows path has the nasty side-effect that it cannot be prefixed with $DESTDIR, and this precludes installing to a staging directory. So, don't convert it.

Signed-off-by: Mark Levedahl <mdl123@verizon.net>
---
(resend, mistyped the git list address)
 git-gui/Makefile |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/git-gui/Makefile b/git-gui/Makefile
index c109eab..8eb9e05 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -119,7 +119,6 @@ GITGUI_MACOSXAPP :=

 ifeq ($(uname_O),Cygwin)
 	GITGUI_SCRIPT := `cygpath --windows --absolute "$(GITGUI_SCRIPT)"`
-	gg_libdir := $(shell cygpath --windows --absolute "$(gg_libdir)")
 else
 	ifeq ($(exedir),$(gg_libdir))
 		GITGUI_RELATIVE := 1
--
1.5.4.rc2.50.gcfa92
Next: Shawn O. Pearce
Message 1 of 5 in “git-gui/Makefile - Don't convert gg_libdir on Cygwin”
  1. git-gui/Makefile - Don't convert gg_libdir on CygwinMark Levedahl, Jan 5, 2008
  2. Shawn O. PearceJan 16, 2008
  3. Mark LevedahlJan 17, 2008
  4. git-gui/Makefile - Handle $DESTDIR on CygwinMark Levedahl, Jan 18, 2008
  5. Shawn O. PearceJan 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.