Re: [StGit PATCH 00/17] Series short description

From: Karl Hasselström <kha@treskal.com>
Date: Dec 18, 2007, 09:24 UTC
Message-ID: <20071218092419.GA16029@diana.vm.bytemark.co.uk>
In-Reply-To: <b0943d9e0712180111l3294e1adj60b5271b9820c60c@mail.gmail.com>

On 2007-12-18 09:11:00 +0000, Catalin Marinas wrote:

Show 10 quoted lines

> On 17/12/2007, Karl Hasselström <kha@treskal.com> wrote:
>
> > Be careful about merging past the "goto" patch -- I'm pretty sure
> > it breaks when called from a subdirectory, and I don't have time
> > to fix that right now. (It should be a clean fix, though -- just
> > adjust the cwd for precisely those git subprocesses that need it,
> > which is very few. I think.)
>
> Why not just change the cwd when the command starts and it should be
> safe for all the git subprocesses.

It doesn't feel very clean to require the caller of some unspecified subset of git calls to remember to set the correct piece of global state.

And the correct solution should really be very simple, since it's precisely the worktree operations (specifically, the subset thereof that have to operate on the whole tree) that require setting cwd. And those are very clearly separated out from the rest in the new infrastructure.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle