Re: [PATCH] add status.relativePaths config variable

From: Jeff King <peff@peff.net>
Date: Dec 8, 2007, 08:02 UTC
Message-ID: <20071208080238.GB4812@coredump.intra.peff.net>
In-Reply-To: <7vaboly6dv.fsf@gitster.siamese.dyndns.org>

On Fri, Dec 07, 2007 at 11:47:56PM -0800, Junio C Hamano wrote:

> Which would make the rewritten patch like this...

Looks like our patches just crossed paths. Yours looks OK, but we should add something to the 'configuration' section, and...

Show 11 quoted lines

> diff --git a/wt-status.h b/wt-status.h
> index 225fb4d..63d50f2 100644
> --- a/wt-status.h
> +++ b/wt-status.h
> @@ -28,6 +28,7 @@ struct wt_status {
>  
>  int git_status_config(const char *var, const char *value);
>  int wt_status_use_color;
> +int wt_status_relative_paths;
>  void wt_status_prepare(struct wt_status *s);
>  void wt_status_print(struct wt_status *s);

Shouldn't both of these ints be marked "extern"? I'm surprised it worked at all (or perhaps the part of my brain that stores C linkage issues is rotting?).

-Peff