[PATCH] avoid "defined but not used" warning for fetch_objs_via_walker
- From
Jeff King <peff@peff.net>
- Date
- Nov 18, 2007, 08:17 UTC
- Message-ID
- <20071118081722.GA31563@sigill.intra.peff.net>
Because this function is static and used only by the http-walker, when NO_CURL is defined, gcc emits a "defined but not used" warning.
Signed-off-by: Jeff King <peff@peff.net> --- On master. I like to compile with -Werror to make sure I don't miss warnings as the compile scrolls by.
This fix feels a little wrong, since the function isn't specific to http support, but hopefully the comment should be obvious if we ever add another similar commit walker that needs it.
transport.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/transport.c b/transport.c index e8a2608..43b9e7c 100644 --- a/transport.c +++ b/transport.c @@ -344,6 +344,7 @@ static int rsync_transport_push(struct transport *transport, /* Generic functions for using commit walkers */ +#ifndef NO_CURL /* http fetch is the only user */ static int fetch_objs_via_walker(struct transport *transport, int nr_objs, struct ref **to_fetch) { @@ -370,6 +371,7 @@ static int fetch_objs_via_walker(struct transport *transport, free(dest); return 0; } +#endif /* NO_CURL */ static int disconnect_walker(struct transport *transport) {
-- 1.5.3.5.1817.gd2b4b-dirty