threads / patch / 10912

patchavoid "defined but not used" warning for fetch_objs_via_walker

Subject: [PATCH] avoid "defined but not used" warning for fetch_objs_via_walker

## tl;dr

3 messages between Nov 18, 2007 and Nov 21, 2007. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Jeff King· Nov 18, 2007, 08:17 UTC · lore

Because this function is static and used only by the http-walker, when NO_CURL is defined, gcc emits a "defined but not used" warning.

Signed-off-by: Jeff King <peff@peff.net>
---
On master. I like to compile with -Werror to make sure I don't miss
warnings as the compile scrolls by.

This fix feels a little wrong, since the function isn't specific to http support, but hopefully the comment should be obvious if we ever add another similar commit walker that needs it.

 transport.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Show changes to transport.c +2 −0
diff --git a/transport.c b/transport.c
index e8a2608..43b9e7c 100644
--- a/transport.c
+++ b/transport.c
@@ -344,6 +344,7 @@ static int rsync_transport_push(struct transport *transport,
 
 /* Generic functions for using commit walkers */
 
+#ifndef NO_CURL /* http fetch is the only user */
 static int fetch_objs_via_walker(struct transport *transport,
 				 int nr_objs, struct ref **to_fetch)
 {
@@ -370,6 +371,7 @@ static int fetch_objs_via_walker(struct transport *transport,
 	free(dest);
 	return 0;
 }
+#endif /* NO_CURL */
 
 static int disconnect_walker(struct transport *transport)
 {

-- 
1.5.3.5.1817.gd2b4b-dirty
Junio C Hamano· Nov 21, 2007, 07:10 UTC · re: Jeff King · lore

Re: [PATCH] avoid "defined but not used" warning for fetch_objs_via_walker

Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> Because this function is static and used only by the
> http-walker, when NO_CURL is defined, gcc emits a "defined
> but not used" warning.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> On master. I like to compile with -Werror to make sure I don't miss
> warnings as the compile scrolls by.
>
> This fix feels a little wrong, since the function isn't specific to http
> support, but hopefully the comment should be obvious if we ever add
> another similar commit walker that needs it.

Yeah, while I share your -Werror desire it sure feels a bit dirty. As it does not look like we will be taking any new walkers, I think your patch is reasonable, though.

Daniel Barkalow· Nov 21, 2007, 18:05 UTC · re: Junio C Hamano · lore

Re: [PATCH] avoid "defined but not used" warning for fetch_objs_via_walker

On Tue, 20 Nov 2007, Junio C Hamano wrote:
Show 18 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Because this function is static and used only by the
> > http-walker, when NO_CURL is defined, gcc emits a "defined
> > but not used" warning.
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> > On master. I like to compile with -Werror to make sure I don't miss
> > warnings as the compile scrolls by.
> >
> > This fix feels a little wrong, since the function isn't specific to http
> > support, but hopefully the comment should be obvious if we ever add
> > another similar commit walker that needs it.
> 
> Yeah, while I share your -Werror desire it sure feels a bit
> dirty.  As it does not look like we will be taking any new
> walkers, I think your patch is reasonable, though.

I think we're likely to do sftp someday, but everything is likely to get reorganized before that anyway.

	-Daniel
*This .sig left intentionally blank*

← back to recent threads