git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Grammar fixes for gitattributes documentation

From
Jeff King <peff@peff.net>
Date
Nov 15, 2007, 07:27 UTC
Message-ID
<20071115072703.GF10185@sigill.intra.peff.net>
In-Reply-To
<ee77f5c20711142320x1a070b21xf00f0853fe09e34c@mail.gmail.com>
On Thu, Nov 15, 2007 at 06:20:10PM +1100, David Symonds wrote:
Show 7 quoted lines
> > >>> +A `filter` attribute can be set to a string value which names a
> > >>> filter driver specified in the configuration.
> 
> "that" should be used to introduce restrictive clauses (as you point
> out), and this use should be a restrictive clause, since you can't set
> the attribute to just any value--you need to set it to the value
> *that* names the desired filter driver.

I don't see it as restrictive, but I can see how one would. I think it is not a case of "this wording is correct" but rather "this wording means one thing, and the other wording means another."

But the two meanings are likely to be interpreted the same way, so I think it isn't a big deal (although "which" without a comma _is_ wrong :) ).

-Peff
Previous: David Symonds
Message 7 of 7 in “Grammar fixes for gitattributes documentation”
  1. Grammar fixes for gitattributes documentationWincent Colaiuta, Nov 14, 2007
  2. Junio C HamanoNov 14, 2007
  3. Wincent ColaiutaNov 14, 2007
  4. Junio C HamanoNov 14, 2007
  5. Jeff KingNov 15, 2007
  6. David SymondsNov 15, 2007
  7. Jeff KingNov 15, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.