Re: [PATCH] Grammar fixes for gitattributes documentation

From: Jeff King <peff@peff.net>
Date: Nov 15, 2007, 07:15 UTC
Message-ID: <20071115071558.GE10185@sigill.intra.peff.net>
In-Reply-To: <3461FD6E-1C46-4278-9EB0-5D730BB99084@wincent.com>

On Wed, Nov 14, 2007 at 10:04:25AM +0100, Wincent Colaiuta wrote:

Show 7 quoted lines

>>> +A `filter` attribute can be set to a string value which names a
>>> filter driver specified in the configuration.
>>
>> Will we get the canned "which vs that" discussion on this change?
>
> Perhaps. Neither would be incorrect, although technically "that" is a 
> tighter match.

Really? I would think "which" works better, in that it is not restrictive. I.e., "The filter attribute is set to a string. This string, btw, names a filter driver" (which) rather than "The filter attribute is set to a string, and from the set of strings, it is set to the particular string that names a filter driver" (that).

But in the non-restrictive case, it should be in a parenthetical phrase:

  A `filter` attribute can be set to a string value, which names a
  filter driver specified in the configuration.

I think either is readable, though. :)

-Peff