git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] --pretty=format: on-demand format expansion

From
Jeff King <peff@peff.net>
Date
Nov 10, 2007, 20:34 UTC
Message-ID
<20071110203435.GB20592@sigill.intra.peff.net>
In-Reply-To
<47359221.7090707@lsrfire.ath.cx>
On Sat, Nov 10, 2007 at 12:12:33PM +0100, René Scharfe wrote:
> Yes, the two are independent.  I don't like the malloc()'s in your
> patch, though, and have cooked up a different one on top of a cleaned up
> version of mine.  It plays the dirty trick of reading expansions of
> repeated placeholders from the strbuf..

Yes, the mallocs would obviously not be necessary for the commit parsing, since we already have a buffer, but I assumed they would be for the abbreviations.

Your solution leaves me partly disgusted at the hackishness, and partly delighted at the cleverness. I think the way you have coded it is quite clear, though, so I don't think anyone is likely to get confused reading it. I haven't read through it carefully yet, but a tentative Ack from me.

-Peff
Previous: Jeff KingNext: Jeff King
Message 15 of 24 in “--pretty=format: on-demand format expansion”
  1. 2/2 --pretty=format: on-demand format expansionRené Scharfe, Nov 9, 2007
  2. Johannes SchindelinNov 9, 2007
  3. René ScharfeNov 9, 2007
  4. Johannes SchindelinNov 9, 2007
  5. Junio C HamanoNov 9, 2007
  6. Jeff KingNov 9, 2007
  7. René ScharfeNov 9, 2007
  8. Johannes SchindelinNov 10, 2007
  9. Jeff KingNov 10, 2007
  10. Jeff KingNov 10, 2007
  11. René ScharfeNov 10, 2007
  12. Johannes SchindelinNov 10, 2007
  13. René ScharfeNov 10, 2007
  14. Jeff KingNov 10, 2007
  15. Jeff KingNov 10, 2007
  16. Jeff KingNov 11, 2007
  17. 1/3 --pretty=format: parse commit message only onceRené Scharfe, Nov 10, 2007
  18. 2/3 add strbuf_adddup()René Scharfe, Nov 10, 2007
  19. 3/3 --format=pretty: avoid calculating expensive expansions twiceRené Scharfe, Nov 10, 2007
  20. Junio C HamanoNov 11, 2007
  21. Jeff KingNov 9, 2007
  22. René ScharfeNov 9, 2007
  23. Jeff KingNov 10, 2007
  24. Paul MackerrasNov 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.