Re: [PATCH 2/2] --pretty=format: on-demand format expansion

From: Jeff King <peff@peff.net>
Date: Nov 9, 2007, 04:52 UTC
Message-ID: <20071109045256.GD31760@sigill.intra.peff.net>
In-Reply-To: <4733AEA6.1040802@lsrfire.ath.cx>

On Fri, Nov 09, 2007 at 01:49:42AM +0100, René Scharfe wrote:

> +	strbuf_expand(sb, format, placeholders, format_commit_item, (void *)commit);

This void cast is pointless, since all pointers types convert implicitly to void pointers anyway. At best, it does nothing, and at worst, it hides an actual type error if the function signature or the type of 'commit' change.

(In the patch I just sent out, I had to change this line anyway, and removed the cast).

-Peff