Re: [PATCH] git-sh-setup: fix parseopt `eval`.

From: Pierre Habouzit <madcoder@debian.org>
Date: Nov 8, 2007, 09:14 UTC
Message-ID: <20071108091402.GA7391@artemis.corp>
In-Reply-To: <7vr6j15i3a.fsf@gitster.siamese.dyndns.org>

On Thu, Nov 08, 2007 at 07:09:29AM +0000, Junio C Hamano wrote:

Show 7 quoted lines

> The 'automagic parseopt' support corrupted non option parameters
> that had IFS characters in them.  The worst case can be seen
> when it has a non option parameter like this:
> 
> 	$1=" * some string   blech"
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

> -	parseopt_extra=
> -	[ -n "$OPTIONS_KEEPDASHDASH" ] &&
> -		parseopt_extra="$parseopt_extra --keep-dashdash"
> +	[ -n "$OPTIONS_KEEPDASHDASH" ] && parseopt_extra="--keep-dashdash"

  oh and this part is wrong because you're affected by $parseopt_extra
environment poisonning. And you have to fix git-clone.sh that uses
git-rev-parse --parsopt directly with the same call too (as it doesn't
use git-sh-setup).

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org