Re: [PATCH] git-sh-setup: fix parseopt `eval`.

From: Pierre Habouzit <madcoder@debian.org>
Date: Nov 8, 2007, 08:15 UTC
Message-ID: <20071108081556.GB6528@artemis.corp>
In-Reply-To: <7vr6j15i3a.fsf@gitster.siamese.dyndns.org>

On Thu, Nov 08, 2007 at 07:09:29AM +0000, Junio C Hamano wrote:

> The 'automagic parseopt' support corrupted non option parameters
> that had IFS characters in them.  The worst case can be seen
> when it has a non option parameter like this:

hu sorry about that, I should have put "" around the ``. I knew it also but it slipped my mind too. I believe this works as well:

eval "$(echo "$OPTIONS_SPEC" | git rev-parse --parseopt $parseopt_extra -- "$@" || echo exit $?)"

I like it better because you will then exit with an exit 129 wich is what we want (and what I documented would work too :P)

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org