Re: [PATCH] Reuse previous annotation when overwriting a tag
- From
Mike Hommey <mh@glandium.org>
- Date
- Nov 3, 2007, 12:27 UTC
- Message-ID
- <20071103122707.GA7227@glandium.org>
- In-Reply-To
- <Pine.LNX.4.64.0711031148460.4362@racer.site>
On Sat, Nov 03, 2007 at 11:54:38AM +0000, Johannes Schindelin wrote:
> Why not teach write_annotations() (or write_tag_body() like I would prefer > it to be called) to grok a null_sha1? It's not like we care for > performance here, but rather for readability and ease of use.
By the way, I think it would be much better if this function was made more generic and would not write, but return an strbuf containing the object body. It could also be used by e.g. git-commit --amend.
What would be the best suited place for such a function ?
Mike