git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] Migrate git-am.sh to use git-rev-parse --parseopt

From
Pierre Habouzit <madcoder@debian.org>
Date
Nov 3, 2007, 12:05 UTC
Message-ID
<20071103120541.GB13417@artemis.corp>
In-Reply-To
<20071103115445.GA13417@artemis.corp>
On Sat, Nov 03, 2007 at 11:54:45AM +0000, Pierre Habouzit wrote:
Show 24 quoted lines
> On Sat, Nov 03, 2007 at 09:55:56AM +0000, Alex Riesen wrote:
> > Pierre Habouzit, Fri, Nov 02, 2007 23:39:52 +0100:
> > > diff --git a/git-am.sh b/git-am.sh
> > > index 2514d07..e5ed6a7 100755
> > > --- a/git-am.sh
> > > +++ b/git-am.sh
> > ....
> > > -	usage ;;
> > > -	*)
> > > -	break ;;
> > > +		-i|--interactive)
> > > +			interactive=t ;;
> > > +		-b|--binary)
> > > +			binary=t ;;
> > 
> > Did you really have to change the indentation?
> 
>   Well, I'm unsure what the standard is for git, I gladly use any
> indentation, I don't really care. I assumed that it wasn't indented
> before becauuse instead of -i|--interactive you had:
> 
>   -i|--in|--int|....|--interactive which took a lot of space, as it
> seemed to me that the case ".." in foo) esac construction in git had the
> cases indented in most places. But I may be wrong.
  Okay seems I was wrong, sorry then, that wasn't done on purpose at
all.
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Previous: Pierre HabouzitNext: Pierre Habouzit
Message 9 of 25 in “let's retry this based on git-rev-parse --parseopt”
  1. Pierre HabouzitNov 2, 2007
  2. 1/5 Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts.Pierre Habouzit, Nov 2, 2007
  3. 2/5 Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseoptPierre Habouzit, Nov 2, 2007
  4. 3/5 Migrate git-clean.sh to use git-rev-parse --parseopt.Pierre Habouzit, Nov 2, 2007
  5. 4/5 Migrate git-clone to use git-rev-parse --parseoptPierre Habouzit, Nov 2, 2007
  6. 5/5 Migrate git-am.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 2, 2007
  7. Alex RiesenNov 3, 2007
  8. Pierre HabouzitNov 3, 2007
  9. Pierre HabouzitNov 3, 2007
  10. 5/5 Migrate git-am.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  11. 6/5 Migrate git-merge.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  12. 8/5 Migrate git-instaweb.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  13. 9/5 Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdashPierre Habouzit, Nov 3, 2007
  14. 10/5 Migrate git-quiltimport.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  15. 11/5 Migrate git-repack.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  16. Junio C HamanoNov 4, 2007
  17. Pierre HabouzitNov 4, 2007
  18. Johannes SchindelinNov 4, 2007
  19. Pierre HabouzitNov 4, 2007
  20. Junio C HamanoNov 4, 2007
  21. 3/5 Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  22. 5/5 Migrate git-clone to use git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  23. 9/5 Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdashPierre Habouzit, Nov 4, 2007
  24. Pierre HabouzitNov 4, 2007
  25. Pierre HabouzitNov 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.