git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] Migrate git-clean.sh to use git-rev-parse --parseopt.

From
Pierre Habouzit <madcoder@debian.org>
Date
Nov 2, 2007, 22:39 UTC
Message-ID
<1194043193-29601-4-git-send-email-madcoder@debian.org>
In-Reply-To
<1194043193-29601-3-git-send-email-madcoder@debian.org>
Also minor consistency tweaks in how errors are caught.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 git-clean.sh |   38 ++++++++++++++++++++------------------
 1 files changed, 20 insertions(+), 18 deletions(-)
diff --git a/git-clean.sh b/git-clean.sh
index 4491738..6959433 100755
--- a/git-clean.sh
+++ b/git-clean.sh
@@ -3,16 +3,21 @@
 # Copyright (c) 2005-2006 Pavel Roskin
 #
 
-USAGE="[-d] [-f] [-n] [-q] [-x | -X] [--] <paths>..."
-LONG_USAGE='Clean untracked files from the working directory
-	-d	remove directories as well
-	-f	override clean.requireForce and clean anyway
-	-n 	don'\''t remove anything, just show what would be done
-	-q	be quiet, only report errors
-	-x	remove ignored files as well
-	-X	remove only ignored files
+OPTIONS_SPEC="\
+git-clean [options] <paths>...
+
+Clean untracked files from the working directory
+
 When optional <paths>... arguments are given, the paths
-affected are further limited to those that match them.'
+affected are further limited to those that match them.
+--
+d remove directories as well
+f override clean.requireForce and clean anyway
+n don't remove anything, just show what would be done
+q be quiet, only report errors
+x remove ignored files as well
+X remove only ignored files"
+
 SUBDIRECTORY_OK=Yes
 . git-sh-setup
 require_work_tree
@@ -55,23 +60,20 @@ do
 		shift
 		break
 		;;
-	-*)
-		usage
-		;;
 	*)
-		break
+		usage # should not happen
+		;;
 	esac
 	shift
 done
 
 if [ "$disabled" = true ]; then
-	echo "clean.requireForce set and -n or -f not given; refusing to clean"
-	exit 1
+	die "clean.requireForce set and -n or -f not given; refusing to clean"
 fi
 
-case "$ignored,$ignoredonly" in
-	1,1) usage;;
-esac
+if [ "$ignored,$ignoredonly" = "1,1" ]; then
+	die "-x and -X cannot be set together"
+fi
 
 if [ -z "$ignored" ]; then
 	excl="--exclude-per-directory=.gitignore"
-- 
1.5.3.5.1460.gdb47
Previous: Pierre HabouzitNext: Pierre Habouzit
Message 4 of 25 in “let's retry this based on git-rev-parse --parseopt”
  1. Pierre HabouzitNov 2, 2007
  2. 1/5 Add a parseopt mode to git-rev-parse to bring parse-options to shell scripts.Pierre Habouzit, Nov 2, 2007
  3. 2/5 Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseoptPierre Habouzit, Nov 2, 2007
  4. 3/5 Migrate git-clean.sh to use git-rev-parse --parseopt.Pierre Habouzit, Nov 2, 2007
  5. 4/5 Migrate git-clone to use git-rev-parse --parseoptPierre Habouzit, Nov 2, 2007
  6. 5/5 Migrate git-am.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 2, 2007
  7. Alex RiesenNov 3, 2007
  8. Pierre HabouzitNov 3, 2007
  9. Pierre HabouzitNov 3, 2007
  10. 5/5 Migrate git-am.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  11. 6/5 Migrate git-merge.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  12. 8/5 Migrate git-instaweb.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  13. 9/5 Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdashPierre Habouzit, Nov 3, 2007
  14. 10/5 Migrate git-quiltimport.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  15. 11/5 Migrate git-repack.sh to use git-rev-parse --parseoptPierre Habouzit, Nov 3, 2007
  16. Junio C HamanoNov 4, 2007
  17. Pierre HabouzitNov 4, 2007
  18. Johannes SchindelinNov 4, 2007
  19. Pierre HabouzitNov 4, 2007
  20. Junio C HamanoNov 4, 2007
  21. 3/5 Update git-sh-setup(1) to allow transparent use of git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  22. 5/5 Migrate git-clone to use git-rev-parse --parseoptPierre Habouzit, Nov 4, 2007
  23. 9/5 Migrate git-checkout.sh to use git-rev-parse --parseopt --keep-dashdashPierre Habouzit, Nov 4, 2007
  24. Pierre HabouzitNov 4, 2007
  25. Pierre HabouzitNov 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.