Re: [PATCH] git-svn: respect Subversion's [auth] section configuration values

From: Eric Wong <normalperson@yhbt.net>
Date: Oct 7, 2007, 21:43 UTC
Message-ID: <20071007214334.GA7442@untitled>
In-Reply-To: <20071007101437.GB3943@void.codelabs.ru>

Eygene Ryabinkin <rea-git@codelabs.ru> wrote:

Show 15 quoted lines

> Eric, Sam, good day.
> Sun, Oct 07, 2007 at 02:24:43PM +1300, Sam Vilain wrote:
> > Eygene Ryabinkin wrote:
> > > Parameters 'store-passwords' and 'store-auth-creds' from Subversion's
> > > configuration (~/.subversion/config) were not respected.  This was
> > > fixed: the default values for these parameters are set to 'yes' to
> > > follow Subversion behaviour.
> > >   
> > 
> > I saw this in the svn api before.  It really is a strange API, requiring
> > the user to get things like this right.
> 
> Yes, the need to parse the configuration and set some flags is
> rather strange.  Looks like nobody cared to stuff the code like
> I had added to the configuration file parsing routines.

I think I started to look at it a while back and forgot about it :)

> > You can use no warnings 'once';
> 
> Great, thanks for the pointer!  Eric, do you want me to produce
> another patch or you'll correct mine?

Go ahead and produce another patch. I haven't had much time to work on git lately.

-- 
Eric Wong