Re: [PATCH] git-svn: respect Subversion's [auth] section configuration values

From: Eygene Ryabinkin <rea-git@codelabs.ru>
Date: Oct 7, 2007, 10:14 UTC
Message-ID: <20071007101437.GB3943@void.codelabs.ru>
In-Reply-To: <4708355B.4090403@vilain.net>

Eric, Sam, good day.

Sat, Oct 06, 2007 at 08:22:41PM -0700, Eric Wong wrote:

Show 7 quoted lines

> Eygene Ryabinkin <rea-git@codelabs.ru> wrote:
> > Parameters 'store-passwords' and 'store-auth-creds' from Subversion's
> > configuration (~/.subversion/config) were not respected.  This was
> > fixed: the default values for these parameters are set to 'yes' to
> > follow Subversion behaviour.
> 
> Thanks.

You're welcome ;))

Sun, Oct 07, 2007 at 02:24:43PM +1300, Sam Vilain wrote:

Show 9 quoted lines

> Eygene Ryabinkin wrote:
> > Parameters 'store-passwords' and 'store-auth-creds' from Subversion's
> > configuration (~/.subversion/config) were not respected.  This was
> > fixed: the default values for these parameters are set to 'yes' to
> > follow Subversion behaviour.
> >   
> 
> I saw this in the svn api before.  It really is a strange API, requiring
> the user to get things like this right.

Yes, the need to parse the configuration and set some flags is rather strange. Looks like nobody cared to stuff the code like I had added to the configuration file parsing routines.

> You can use no warnings 'once';

Great, thanks for the pointer! Eric, do you want me to produce another patch or you'll correct mine?

-- 
Eygene