Re: [PATCH/RFT] cvsserver: only allow checkout of branches

From: Jan Wielemaker <wielemak@science.uva.nl>
Date: Oct 4, 2007, 17:06 UTC
Message-ID: <200710041906.21004.wielemak@science.uva.nl>
In-Reply-To: <Pine.LNX.4.64.0710041622070.4174@racer.site>

On Thursday 04 October 2007 17:29, Johannes Schindelin wrote:

> It does not make sense to check out tags or "HEAD".
>
> Noticed by Jan Wielemaker.

Thanks (though it won't bite me a second time :-)

> ) +    {
> +	$log->warn("Checkout failed: $module is not a branch");
> +	print "error 1 Checkout failed: $module is not a branch\n";

There are various places where it says print "...", one that even started some suggestion on what might be wrong, but these things don't end up at a visible place when using ssh as transport. Its a good idea this one is at least in the logfile as well. Not sure, but might printing to stderr work better?

	Cheers --- Jan