git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFT] cvsserver: only allow checkout of branches

From
Frank Lichtenheld <frank@lichtenheld.de>
Date
Oct 4, 2007, 16:18 UTC
Message-ID
<20071004161812.GA31659@planck.djpig.de>
In-Reply-To
<Pine.LNX.4.64.0710041622070.4174@racer.site>
On Thu, Oct 04, 2007 at 04:29:04PM +0100, Johannes Schindelin wrote:
Show 22 quoted lines
> 	Cc'ed Frank, who is de-facto maintainer (according to shortlog) 
> 	and Martin, who started it all IIRC.
> 
> diff --git a/git-cvsserver.perl b/git-cvsserver.perl
> index 13dbd27..869690c 100755
> --- a/git-cvsserver.perl
> +++ b/git-cvsserver.perl
> @@ -770,6 +770,14 @@ sub req_co
>  
>      $log->debug("req_co : " . ( defined($data) ? $data : "[NULL]" ) );
>  
> +    if( system("git", "rev-parse", "--verify", "refs/heads/$module" ) != 0 )
> +    {
> +	$log->warn("Checkout failed: $module is not a branch");
> +	print "error 1 Checkout failed: $module is not a branch\n";
> +	chdir "/";
> +	exit;
> +    }
> +
>      $log->info("Checking out module '$module' ($state->{CVSROOT}) to '$checkout_path'");
>  
>      $ENV{GIT_DIR} = $state->{CVSROOT} . "/";

Looks good, haven't tested it yet, though. Care to add a testcase or should I take care of that?

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 12 of 19 in “git-cvsserver commit trouble (unexpected end of file in client)”
  1. Jan WielemakerOct 3, 2007
  2. Jan WielemakerOct 3, 2007
  3. Jan WielemakerOct 3, 2007
  4. Johannes SchindelinOct 3, 2007
  5. Jan WielemakerOct 3, 2007
  6. Johannes SchindelinOct 3, 2007
  7. Jan WielemakerOct 4, 2007
  8. Jan WielemakerOct 4, 2007
  9. Johannes SchindelinOct 4, 2007
  10. Jan WielemakerOct 4, 2007
  11. cvsserver: only allow checkout of branchesJohannes Schindelin, Oct 4, 2007
  12. Frank LichtenheldOct 4, 2007
  13. Johannes SchindelinOct 4, 2007
  14. Jan WielemakerOct 4, 2007
  15. Johannes SchindelinOct 4, 2007
  16. Frank LichtenheldOct 4, 2007
  17. Frank LichtenheldOct 4, 2007
  18. Johannes SchindelinOct 4, 2007
  19. Shawn O. PearceOct 4, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.