Re: [PATCH 1/4] Add a simple option parser for use by builtin-commit.c.

From: Jonas Fonseca <fonseca@diku.dk>
Date: Oct 1, 2007, 10:31 UTC
Message-ID: <20071001103148.GC8315@diku.dk>
In-Reply-To: <Pine.LNX.4.64.0710011114310.28395@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote Mon, Oct 01, 2007:

Show 11 quoted lines

> Hi,
> 
> On Sun, 30 Sep 2007, Jonas Fonseca wrote:
> 
> > Also, I think for this to be more usable for other built-in programs it 
> > shouldn't modify argv, but instead take both argc and argv (so we don't 
> > need to have code like "*++(*argv)" ;), parse _all_ options in one go, 
> > and return the index (of argv) for any remaining options.
> 
> We _have_ to modify argv.  For example, "git log master -p" is perfectly 
> valid.

Ah, yes this could be nice to also finally have (more universally) in git. But for this to be possible I don't see any reason for it to modify the pointer to argv. Instead, it can just reshuffle entries in argv.

-- 
Jonas Fonseca