git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] This exports the update() function from builtin-add.c as

From
Kristian Høgsberg <krh@redhat.com>
Date
Oct 3, 2007, 22:03 UTC
Message-ID
<1191449034.7134.19.camel@hinata.boston.redhat.com>
In-Reply-To
<7v7imcv5op.fsf@gitster.siamese.dyndns.org>

On Thu, 2007-09-27 at 02:05 -0700, Junio C Hamano wrote: ...

Show 29 quoted lines
> I think the right organization for the "builtin-commit" series
> should be:
> 
>  * merge strbuf topic in kh/commit topic, in order to get the
>    stripspace updates and strbuf_read_file();
> 
>  * add--interactive entry point change (respin the one from the
>    old series);
> 
>  * rename update() to add_files_to_cache() and export (respin
>    this [2/4] with a better commit message);
> 
>  * create a separate rerere() function and export (respin part
>    of old series, with proper refactoring);
> 
>    I am not happy with builtin-foo.c calling into something from
>    builtin-bar.c, though.  We probably would want to move
>    rerere() and add_files_to_cache() somewhere else.
> 
>  * move launch_editor() and stripspace() to create editor.c (new
>    [4/4]);
> 
>  * add option parser in parse-options.[ch] (new [1/4]);
> 
>  * finally, create builtin-commit that uses the groundwork laid
>    out above (new [3/4]).
> 
> I ended up doing the above up to the rerere() one myself, but
> haven't done the rest.
>From what I see in next today, it looks like we're just missing the

parse-options patch and builtin-commit patches. I resent a better version of parse-options and a patch that ports builtin-add.c to the option parser. To use the option parser in more places, we'll probably have to extend it a bit, but the patch is a good start. Let's get that in shape and into next and then I'll send an updated builtin-commit patch.

thanks, Kristian

Previous: Junio C HamanoNext: Johannes Schindelin
Message 6 of 17 in “Add a simple option parser for use by builtin-commit.c.”
  1. 1/4 Add a simple option parser for use by builtin-commit.c.Kristian Høgsberg, Sep 27, 2007
  2. 2/4 This exports the update() function from builtin-add.c asKristian Høgsberg, Sep 27, 2007
  3. 3/4 Implement git commit as a builtin command.Kristian Høgsberg, Sep 27, 2007
  4. 4/4 Move launch_editor() and stripspace() to new file editor.c.Kristian Høgsberg, Sep 27, 2007
  5. Junio C HamanoSep 27, 2007
  6. Kristian HøgsbergOct 3, 2007
  7. Johannes SchindelinSep 27, 2007
  8. Junio C HamanoSep 27, 2007
  9. Jonas FonsecaSep 30, 2007
  10. Johannes SchindelinOct 1, 2007
  11. Jonas FonsecaOct 1, 2007
  12. Johannes SchindelinOct 1, 2007
  13. Jeff KingOct 1, 2007
  14. Kristian HøgsbergOct 1, 2007
  15. Johannes SchindelinOct 1, 2007
  16. Jonas FonsecaOct 3, 2007
  17. Kristian HøgsbergOct 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.