Re: [PATCH 4/4] t6000lib: workaround a possible dash bug

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sep 21, 2007, 13:28 UTC
Message-ID: <20070921132808.GB9778@gondor.apana.org.au>
In-Reply-To: <11486091792604-git-send-email-normalperson@yhbt.net>

Hi Eric:

On Thu, May 25, 2006 at 07:06:18PM -0700, Eric Wong wrote:

Show 7 quoted lines

> pdksh doesn't need this patch, of course bash works fine since
> that what most users use.
> 
> Normally, 'var=val command' seems to work fine with dash, but
> perhaps there's something weird going on with "$@".  dash is
> pretty widespread, so it'll be good to support this even though
> it does seem like a bug in dash.

Just going through dash issues right now. Do you recall what the bug is in this case? Doing a quick test doesn't seem to show much:

dash -c 'set -- env; a=b "$@"'

Show 17 quoted lines

> diff --git a/t/t6000lib.sh b/t/t6000lib.sh
> index c6752af..d402621 100755
> --- a/t/t6000lib.sh
> +++ b/t/t6000lib.sh
> @@ -69,7 +69,9 @@ on_committer_date()
>  {
>      _date=$1
>      shift 1
> -    GIT_COMMITTER_DATE=$_date "$@"
> +    export GIT_COMMITTER_DATE="$_date"
> +    "$@"
> +    unset GIT_COMMITTER_DATE
>  }
>  
>  # Execute a command and suppress any error output.
> -- 
> 1.3.2.g7d11

Thanks,

-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt