Re: [PATCH 4/4] t6000lib: workaround a possible dash bug

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: May 26, 2006, 12:33 UTC
Message-ID: <20060526123342.GD5372@gondor.apana.org.au>
In-Reply-To: <11486091792604-git-send-email-normalperson@yhbt.net>

On Thu, May 25, 2006 at 07:06:18PM -0700, Eric Wong wrote:

Show 17 quoted lines

>
>  t/t6000lib.sh |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> cba907ce0b1c0927fb15cbb5dd91a4129ff9a950
> diff --git a/t/t6000lib.sh b/t/t6000lib.sh
> index c6752af..d402621 100755
> --- a/t/t6000lib.sh
> +++ b/t/t6000lib.sh
> @@ -69,7 +69,9 @@ on_committer_date()
>  {
>      _date=$1
>      shift 1
> -    GIT_COMMITTER_DATE=$_date "$@"
> +    export GIT_COMMITTER_DATE="$_date"
> +    "$@"
> +    unset GIT_COMMITTER_DATE

The original code looks correct to me. So I think this too should be fixed in dash instead.

Thanks,

-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt