Re: [PATCH] [git-p4] Detect exec bit in more cases.

From: Simon Hausmann <simon@lst.de>
Date: Sep 21, 2007, 10:20 UTC
Message-ID: <200709211220.05434.simon@lst.de>
In-Reply-To: <7vodfxj6db.fsf@gitster.siamese.dyndns.org>

On Friday 21 September 2007 00:53:52 Junio C Hamano wrote:

Show 20 quoted lines

> David Brown <git@davidb.org> writes:
> > On Wed, Sep 19, 2007 at 09:03:50PM +0200, Simon Hausmann wrote:
> >>On Wednesday 19 September 2007 20:15:03 David Brown wrote:
> >>> git-p4 was missing the execute bit setting if the file had other
> >>> attribute bits set.
> >>> ---
> >>
> >>I'm fine with this, so unless you find a better way:
> >>
> >>Acked-By: Simon Hausmann <simon@lst.de>
> >
> > I sent out an improved version of this patch yesterday
> > <1190232768445-git-send-email-git@davidb.org> that I'd like to get
> > approved.  I guess I'm not quite sure what happens at this point with a
> > patch.
>
> I still have that *768445* message as "the last one proposed as
> better than previous ones" in my mbox.
>
> Simon?

Indeed, the new improved version is much better :)

Acked-By: Simon Hausmann <simon@lst.de>

Simon