Re: [PATCH 1/3] git-gui/Makefile: Replace libdir with gitgui_libdir

From: Dmitry V. Levin <ldv@altlinux.org>
Date: Sep 7, 2007, 12:44 UTC
Message-ID: <20070907124454.GD31861@basalt.office.altlinux.org>
In-Reply-To: <20070907050148.GA18160@spearce.org>

On Fri, Sep 07, 2007 at 01:01:48AM -0400, Shawn O. Pearce wrote:

Show 11 quoted lines

> "Dmitry V. Levin" <ldv@altlinux.org> wrote:
> > > "Dmitry V. Levin" <ldv@altlinux.org> wrote:
> > > > On GNU/Linux, libdir is used to mean "/usr/lib or /usr/lib64"
> > > > depending on architecture.  Different libdir meaning breaks
> > > > idiomatic expressions like rpm specfile "make libdir=%_libdir".
> > 
> > The idea is that git-gui's libdir is not a traditional arch-dependent
> > libdir's subdirectory, but rather arch-independent datadir's subdirectory.
> > That is, I see no reason to call it libdir even in standalone project.
> 
> Call it datadir then?  I see you point, and now agree with you.

I'm not sure that "datadir" is better choice than current "libdir". First, from git-gui point of view, files placed in git-gui/lib/ are rather library files than data files. Second, if top-level makefile will define "datadir", original issue will raise again. That's why I suggested to add some git-gui specific component to git-gui's libdir variable name.

-- 
ldv