Re: [PATCH 1/3] git-gui/Makefile: Replace libdir with gitgui_libdir

From: Dmitry V. Levin <ldv@altlinux.org>
Date: Sep 6, 2007, 10:00 UTC
Message-ID: <20070906100012.GC6665@basalt.office.altlinux.org>
In-Reply-To: <20070906023227.GH18160@spearce.org>

On Wed, Sep 05, 2007 at 10:32:27PM -0400, Shawn O. Pearce wrote:

Show 12 quoted lines

> "Dmitry V. Levin" <ldv@altlinux.org> wrote:
> > On GNU/Linux, libdir is used to mean "/usr/lib or /usr/lib64"
> > depending on architecture.  Different libdir meaning breaks
> > idiomatic expressions like rpm specfile "make libdir=%_libdir".
> > 
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> > ---
> >  git-gui/Makefile |   16 ++++++++--------
> >  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> Although I could apply this with `am -3` I'm NACK'ing this right
> now because...

[...]

> git-gui is its own project with its own Makefile.  Junio includes
> it in git.git to help widen its audience, and because it is quite
> portable and easy for him to include.   In the future git-gui will
> become a proper subproject of git.git.

The idea is that git-gui's libdir is not a traditional arch-dependent libdir's subdirectory, but rather arch-independent datadir's subdirectory. That is, I see no reason to call it libdir even in standalone project.

> If you want to define libdir in git's toplevel Makefile *and*
> that definition is being exported down into git-gui's Makefile

Yes, that was my first motivation, but the issue appears to be a bit more complex.

-- 
ldv