git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] gitweb: Support for arbitrary diffs

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 3, 2007, 08:23 UTC
Message-ID
<200709031023.42366.jnareb@gmail.com>
In-Reply-To
<20070903013330.GR1219@pasky.or.cz>
On Mon, 3 September 2007, Petr "Pasky" Baudis wrote:
Show 5 quoted lines
> To hijack this post a bit, another patch in the queue (the incremental
> blame thingie) introduces blame.js. Do you think that we should keep the
> .js files separate, or instead have one big gitweb.js with everything?
> I'm inclined to the second possibility in order to reduce the number of
> requests, but it comes at a price of slightly worse maintainability.

On the other hand if we have blame.js separate, we could load it (require it) only for the 'blame' view, it means only when needed.

gitweb.js would contain JavaScript code used by all (or almost all) views, then...

I don't think gitweb.js would be as large as gitweb.perl, if we are talking about maintability ;-)

-- 
Jakub Narebski
Poland
Previous: Junio C HamanoNext: Martin Koegler
Message 10 of 12 in “gitweb: Support for arbitrary diffs”
  1. 0/5 gitweb: Support for arbitrary diffsMartin Koegler, Sep 2, 2007
  2. 1/5 gitweb: Support comparing blobs with different namesMartin Koegler, Sep 2, 2007
  3. 2/5 gitweb: support filename prefix in git_patchset_body/git_difftree_bodyMartin Koegler, Sep 2, 2007
  4. 3/5 gitweb: Add treediff viewMartin Koegler, Sep 2, 2007
  5. 4/5 gitweb: Selecting diffs in JavaScriptMartin Koegler, Sep 2, 2007
  6. 5/5 Show Difflinks in an other colorMartin Koegler, Sep 2, 2007
  7. Jakub NarebskiSep 3, 2007
  8. Petr BaudisSep 3, 2007
  9. Junio C HamanoSep 3, 2007
  10. Jakub NarebskiSep 3, 2007
  11. Martin KoeglerSep 4, 2007
  12. Catalin MarinasSep 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.