git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] gitweb: Support for arbitrary diffs

From
Petr Baudis <pasky@suse.cz>
Date
Sep 3, 2007, 01:33 UTC
Message-ID
<20070903013330.GR1219@pasky.or.cz>
In-Reply-To
<fbfjtl$7gh$1@sea.gmane.org>
On Mon, Sep 03, 2007 at 02:19:05AM CEST, Jakub Narebski wrote:
Show 11 quoted lines
> [Cc: Martin Koegler <mkoegler@auto.tuwien.ac.at>,
>      Petr Baudis <pasky@suse.cz>, git@vger.kernel.org]
> 
> Martin Koegler wrote:
> 
> > Patch 4 now only generates the links, if they are enabled.
> > The header contains a new link to show/hide the links.
> > The state is remembered via a cookie across pages.
> 
> I'd rather have patch adding cookie management (are they only JavaScript,
> or also server side?) as a separate patch.

This is purely in-Javascript thing, so I don't think a separate patch makes much sense.

To hijack this post a bit, another patch in the queue (the incremental blame thingie) introduces blame.js. Do you think that we should keep the .js files separate, or instead have one big gitweb.js with everything? I'm inclined to the second possibility in order to reduce the number of requests, but it comes at a price of slightly worse maintainability.

-- 
				Petr "Pasky" Baudis
Early to rise and early to bed makes a male healthy and wealthy and dead.
                -- James Thurber
Previous: Jakub NarebskiNext: Junio C Hamano
Message 8 of 12 in “gitweb: Support for arbitrary diffs”
  1. 0/5 gitweb: Support for arbitrary diffsMartin Koegler, Sep 2, 2007
  2. 1/5 gitweb: Support comparing blobs with different namesMartin Koegler, Sep 2, 2007
  3. 2/5 gitweb: support filename prefix in git_patchset_body/git_difftree_bodyMartin Koegler, Sep 2, 2007
  4. 3/5 gitweb: Add treediff viewMartin Koegler, Sep 2, 2007
  5. 4/5 gitweb: Selecting diffs in JavaScriptMartin Koegler, Sep 2, 2007
  6. 5/5 Show Difflinks in an other colorMartin Koegler, Sep 2, 2007
  7. Jakub NarebskiSep 3, 2007
  8. Petr BaudisSep 3, 2007
  9. Junio C HamanoSep 3, 2007
  10. Jakub NarebskiSep 3, 2007
  11. Martin KoeglerSep 4, 2007
  12. Catalin MarinasSep 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.