Re: [StGIT PATCH 0/4] Miscellaneous fixes

From: Karl Hasselström <kha@treskal.com>
Date: Aug 29, 2007, 11:17 UTC
Message-ID: <20070829111759.GB29980@diana.vm.bytemark.co.uk>
In-Reply-To: <b0943d9e0708290318k715cb94eidfa38a97825511ca@mail.gmail.com>

On 2007-08-29 11:18:34 +0100, Catalin Marinas wrote:

Show 18 quoted lines

> On 26/08/2007, Karl Hasselström <kha@treskal.com> wrote:
>
> >   git://repo.or.cz/stgit/kha.git fixes
> >
> > Karl Hasselström (4):
> >       Don't use test_expect_failure when more than one thing could fail
> >       Don't write None to the conf file
> >       Replace "git repo-config" with "git config" in help texts
> >       Compile regexp just once
> >
> >  examples/gitconfig          |    2 +-
> >  stgit/git.py                |    3 ++-
> >  stgit/stack.py              |    7 ++++---
> >  t/t2101-pull-policy-pull.sh |    4 ++--
> >  4 files changed, 9 insertions(+), 7 deletions(-)
>
> BTW, did you generate the above text by hand and copied it to the
> e-mail?

Yes. It's the output of git-request-pull.

> People asked in the past for this kind of text to be automatically
> generated by 'stg mail'.

I might very well have been one of them.

Adding cover message template support for shortlog and aggregate diffstat should be straightforward. I might get to it some time in the not too distant future if no one else beats me to it. As for the pull line, that's another story; git-request-pull actually seems to connect to that repository and check its contents, and I'm not convinced that's a good thing for stg-mail to be doing. But that's the least wanted item of the three anyway, I guess.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle