git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGIT PATCH 4/4] Compile regexp just once

From
Karl Hasselström <kha@treskal.com>
Date
Aug 26, 2007, 20:26 UTC
Message-ID
<20070826202632.15933.99722.stgit@yoghurt>
In-Reply-To
<20070826202309.15933.54183.stgit@yoghurt>

It's a waste of time to recompile the same regexp every time we go through the loop.

Signed-off-by: Karl Hasselström <kha@treskal.com>
---
 stgit/git.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/stgit/git.py b/stgit/git.py
index 1807f69..14b4c81 100644
--- a/stgit/git.py
+++ b/stgit/git.py
@@ -275,8 +275,9 @@ def local_changes(verbose = True):
 
 def get_heads():
     heads = []
+    hr = re.compile(r'^[0-9a-f]{40} refs/heads/(.+)$')
     for line in _output_lines(['git-show-ref', '--heads']):
-        m = re.match('^[0-9a-f]{40} refs/heads/(.+)$', line)
+        m = hr.match(line)
         heads.append(m.group(1))
     return heads
 
Previous: Karl HasselströmNext: Catalin Marinas
Message 5 of 8 in “Miscellaneous fixes”
  1. 0/4 Miscellaneous fixesKarl Hasselström, Aug 26, 2007
  2. 1/4 Don't use test_expect_failure when more than one thing could failKarl Hasselström, Aug 26, 2007
  3. 2/4 Don't write None to the conf fileKarl Hasselström, Aug 26, 2007
  4. 3/4 Replace "git repo-config" with "git config" in help textsKarl Hasselström, Aug 26, 2007
  5. 4/4 Compile regexp just onceKarl Hasselström, Aug 26, 2007
  6. Catalin MarinasAug 29, 2007
  7. Karl HasselströmAug 29, 2007
  8. Catalin MarinasSep 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.